This repository was archived by the owner on Mar 24, 2026. It is now read-only.
[Dart3] fix dart3_aot regression#10835
Merged
msmith-techempower merged 4 commits intoMar 2, 2026
Merged
Conversation
Contributor
|
The following frameworks were updated, pinging maintainers: |
msmith-techempower
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves a significant performance regression in the
dart-aotbenchmark (Regression Trace vs Baseline).The regression was inadvertently introduced during a previous attempt to simplify the codebase for better readability.
These changes restore the optimized isolate initialization pattern while maintaining the improved code architecture.
Changes
async/awaithandshake duringmainand isolate startup to ensure full CPU saturation under load._requestTimeoutand error boundaries to prevent stalled connections from blocking the isolate event loop.dart3_nativeimplementation.Interestingly, while the
nativeversion appeared unaffected by the logic that regressedAOT, mirroring the code ensures a strict 1-to-1 architectural comparison between the two implementations.